From 94680cbffc1670e1fd0ebb2a3a9895eac08b1b04 Mon Sep 17 00:00:00 2001 From: Kristian Rietveld Date: Mon, 8 Oct 2007 12:44:35 +0000 Subject: [PATCH] don't "corrupt" all iterators by reversing the list after adding the 2007-10-08 Kristian Rietveld * gtk/gtkfilesystemmodel.c (got_root_folder_cb), (get_children_get_folder_cb): don't "corrupt" all iterators by reversing the list after adding the items. Reversing the list isn't needed anyway as the order of the items in the model does not matter. (Fixes #327243, comment 10). svn path=/trunk/; revision=18891 --- ChangeLog | 8 ++++++++ gtk/gtkfilesystemmodel.c | 4 ---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 915323ceb4..4fd62b3c24 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2007-10-08 Kristian Rietveld + + * gtk/gtkfilesystemmodel.c (got_root_folder_cb), + (get_children_get_folder_cb): don't "corrupt" all iterators by + reversing the list after adding the items. Reversing the list isn't + needed anyway as the order of the items in the model does not matter. + (Fixes #327243, comment 10). + 2007-10-08 Kristian Rietveld Fix #482841, patch by Karl Tomlinson. diff --git a/gtk/gtkfilesystemmodel.c b/gtk/gtkfilesystemmodel.c index f6be38fc11..8d67165a2c 100644 --- a/gtk/gtkfilesystemmodel.c +++ b/gtk/gtkfilesystemmodel.c @@ -664,8 +664,6 @@ got_root_folder_cb (GtkFileSystemHandle *handle, } g_slist_free (roots); - model->roots = (FileModelNode *) g_slist_reverse ((GSList *)model->roots); - out: g_object_unref (model); g_object_unref (handle); @@ -1577,8 +1575,6 @@ get_children_get_folder_cb (GtkFileSystemHandle *handle, g_slist_free (child_paths); } - data->node->children = (FileModelNode *)g_slist_reverse ((GSList *)data->node->children); - g_signal_connect (data->node->folder, "deleted", G_CALLBACK (deleted_callback), data->node); g_signal_connect (data->node->folder, "files-added", -- 2.30.2